fix(topology): delete action should be available for custom targets #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tthvo
force-pushed
the
topology-delete-action
branch
from
5332e75
to
0e822c2
Compare
|
Looks like it worked - the deletion button appears again, and after clicking it I can see a request sent and success response from the server, and a "target lost" notification. However, the Topology view didn't update on the notification, so I had to navigate away and back to see the updated view state. Seems like a separate bug, but worth noting. In testing cryostatio/cryostat#407 it looks like Agents deregistering also doesn't trigger Topology to update, so it could be a common root cause. |
andrewazores
force-pushed
the
topology-delete-action
branch
from
0e822c2
to
8d80dfb
Compare
andrewazores
approved these changes
Apr 24, 2024
|
Bypassed the rule this time, but @tthvo please set up your GPG signature again with this email account :-) |
|
Ohh oops! That's odd. Somehow, the commit signature keep being not recognized again...I will check next time :D Thanks :))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: #1251
Description of the change:
allowListandblockListto be more flexible based on the tree element.REALMannotation to ensure that only Custom Target is allowed to be deleted.Motivation for the change:
See #1251